From: Jasper St. Pierre Date: Sat, 16 Feb 2013 17:44:04 +0000 (-0500) Subject: grabHelper: Correct typo preventing focus-window-changed disconnect X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~1013^2^2~4821 X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=5f995c64d4b9af9c2cede2bed530482128a04429;p=gnome-shell.git grabHelper: Correct typo preventing focus-window-changed disconnect While debugging, I found that the signal to focus-window-changed was never getting disconnected, making a call to ungrab every time the focus window changed, even if there were no focus grabs anymore. https://bugzilla.gnome.org/show_bug.cgi?id=693975 --- diff --git a/js/ui/grabHelper.js b/js/ui/grabHelper.js index 0c0e190d5..058524ae8 100644 --- a/js/ui/grabHelper.js +++ b/js/ui/grabHelper.js @@ -232,7 +232,7 @@ const GrabHelper = new Lang.Class({ this._keyFocusNotifyId = 0; } - if (!this._focusWindowChanged > 0) { + if (this._focusWindowChangedId > 0) { let metaDisplay = global.screen.get_display(); metaDisplay.disconnect(this._focusWindowChangedId); this._focusWindowChangedId = 0;